Fixes and refactorings related to using mnsync in tests#3136
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Oct 9, 2019
Merged
Fixes and refactorings related to using mnsync in tests#3136UdjinM6 merged 2 commits intodashpay:developfrom
UdjinM6 merged 2 commits intodashpay:developfrom
Conversation
Author
|
Rebased to fix merge conflicts after #3127 |
…ntroduce `force_finish_mnsync` for MNs only
…d drop local unused functions Also move the call, `force_finish_mnsync` should be called before `connect_nodes_bi`
nmarley
approved these changes
Oct 9, 2019
nmarley
left a comment
nmarley
left a comment
There was a problem hiding this comment.
utACK
(from test_framework.util import * makes me cringe a bit, not related to this refactoring though.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #3127 I suggested that we should keep
sync_masternodesassuming it was helping tests to pass... but after digging a bit I realized that I was wrong and we don't needsync_masternodesandwait_to_syncin tests that do not use MNs at all actually. These functions were introduced in #950 back when we had non-deterministic MN list. They are still useful for MN test nodes (MNs won't accept incoming connections while syncing, there is actually a bug related to this indip3-deterministicmns.pywhich is fixed in the second commit) but we can drop them everywhere else. Also, there is no need for the "slow" sync mode, it's always the "fast" one now and we can simplify the function.